-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix for #2969 #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #2969 #3100
Conversation
Could you please give this commit a proper commit message, that describes what it does? Just referencing to an issue isn't very friendly wrt searching / scanning of the commit log, and makes the commit message useless if the issue list ever gets lost. If you want to refer to an issue, use the "Fixes #2969" syntax somewhere in the commit message body (i.e. not the first line), which will even cause github to autoclose the issue. |
The new example code in the repo with address 8 looks ok, it might also be useful to update the actual web page here: |
Indeed @agdl . This is not the first time. Hopefully it's the last |
Huh? I'm now totally lost. |
@bperrybap the on-line page take the code from git so it is automatically updated when the PR is merged. For the descriptive part i added this statement here: "However the addresses from 0 to 7 are not used because are reserved so the first address that can be used is 8. " |
Cool. Very nice. Thank You. |
Why is this closed? |
So @agdl can make another one, with a proper commit message, and a proper PR title and a proper PR description |
No description provided.